Update error messages on update-childcare-screen #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sree-cfa
reviewed
Feb 29, 2024
sree-cfa
reviewed
Feb 29, 2024
Comment on lines
49
to
50
| errors.future-childcare-date-outside-of-range=Past date entered for future child care start date: Please choose a future start date | ||
| errors.past-childcare-date-out-of-range=Past child care start date outside range 01/01/1901 - today: Please choose a start date between 01/01/1901 and today |
There was a problem hiding this comment.
I think we can get rid of the part before the colon here too
Suggested change
| errors.future-childcare-date-outside-of-range=Past date entered for future child care start date: Please choose a future start date | |
| errors.past-childcare-date-out-of-range=Past child care start date outside range 01/01/1901 - today: Please choose a start date between 01/01/1901 and today | |
| errors.future-childcare-date-outside-of-range=Please choose a future start date | |
| errors.past-childcare-date-out-of-range=Please choose a start date between 01/01/1901 and today |
|
@enyia21 can you also do a rebase? Some changes from main are showing up in the diff |
#187090179 Co-authored-by: Cypress Borg <[email protected]>
#187090179 Co-authored-by: Cypress Borg <[email protected]>
enyia21
force-pushed
the
update-childcare-start-screen-error-text
branch
from
5269bdb to
8069ee3
Compare
sree-cfa
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#187090179
🔗 Pivotal Tracker ticket
✍️ Description
📷 Design reference
✅ Completion tasks