[CCAP-453][CCAP-439][CCAP-537] Update content on providerresponse/provider-number screen, update provider id validation logic, remove broken link #869
Conversation
cram-cfa
changed the title
cram-cfa
changed the title
| @@ -35,7 +35,7 @@ | |||
| <th:block | |||
| th:replace="~{fragments/inputs/submitButton :: submitButton(text=${buttonLabel != null ? buttonLabel : 'Submit'})}"/> | |||
| <div> | |||
| <a th:if="hasSkipLocation" | |||
| <a th:if="${hasSkipLocation}" | |||
There was a problem hiding this comment.
This was apparently always broken, fwiw.
| @@ -237,7 +238,7 @@ onboarding-provider-info-review.link=Edit their info | |||
| #onboarding-provider-info-confirm | |||
| onboarding-provider-info-confirm.title=Confirm provider info | |||
| onboarding-provider-info-confirm.header=Thanks! Now we can help you contact {0} when you''re done. | |||
| onboarding-provider-info-confirm.notice=<div class='notice--success spacing-below-60'><p>At the end of this application, you'll have the option to <strong>text or email a secure link</strong> to '{0}'.</p><p>Using the link, your provider can quickly complete their part of the application.</p></div> | |||
| onboarding-provider-info-confirm.notice=<div class='notice--success spacing-below-60'><p>At the end of this application, you''ll have the option to <strong>text or email a secure link</strong> to '{0}'.</p><p>Using the link, your provider can quickly complete their part of the application.</p></div> | |||
There was a problem hiding this comment.
I noticed this typo, missing the double apostrophe, when clicking through the app and fixed it here.
| errorMessages.put(PROVIDER_NUMBER, | ||
| List.of(messageSource.getMessage("provider-response-ccap-registration.error.invalid-number", null, locale))); | ||
|
|
||
| if (inputValue == null || inputValue.isBlank()) { |
There was a problem hiding this comment.
I love the most specific error messages here. I think it makes it much clearer what the actual issue is.
| import org.springframework.stereotype.Repository; | ||
|
|
||
| @Repository | ||
| public interface ProviderRepository extends JpaRepository<Provider, BigInteger> { | ||
|
|
||
| @Query(value = "SELECT CASE WHEN COUNT(*) > 0 THEN TRUE ELSE FALSE END FROM providers " |
There was a problem hiding this comment.
I tunneled into staging and tested this query using psql. the test worked :)
| @@ -522,22 +522,18 @@ flow: | |||
| nextScreens: | |||
| - name: paid-by-ccap | |||
| condition: EnableProviderRegistration | |||
| - name: ccap-registration | |||
| - name: provider-number | |||
There was a problem hiding this comment.
@spokenbird - heads up that this PR is actually renaming the ccap-registration screen to provider-number so it will actually always appear at the beginning of the flow. This means that you probably no longer need to add the GenerateDummyClientSubmissionForDev to the paid by CCAP screen
There was a problem hiding this comment.
Tested the query ✅ , Reviewed the provider-number screen ✅ , confirmed that the link to saying no provider is gone and now on the provider-number screen ✅
Made a few recommended changes. The only blocking one is related to the missing apostrophe on provider-info-confirm
Co-authored-by: Ana Medrano Fernandez <[email protected]>
Co-authored-by: Ana Medrano Fernandez <[email protected]>
🔗 Jira ticket
✍️ Description
📷 Design reference
✅ Completion tasks