Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCAP-510] Updated Homepage Copy #920

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

enyia21
Copy link
Contributor

@enyia21 enyia21 commented Dec 16, 2024

🔗 Jira ticket

CCAP-510

✍️ Description

Updated Copy for homepage screen

📷 Design reference

Figma

✅ Completion tasks

  • Added relevant tests
  • Meets acceptance criteria

@github-actions github-actions bot requested a review from spokenbird December 16, 2024 20:23
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-510-update--ic522x December 16, 2024 20:25 Inactive
@cram-cfa
Copy link
Contributor

Is this ready for review? (There's no label on it, so just confirming)

Copy link
Contributor

@cram-cfa cram-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth, in the future... if we know the work is just updating text that's in Transifex, kick the ticket back to Carlie or Carl and have them just do the changes in Transifex.

But anyway, for this one since you already did it... @enyia21 Have you added the Spanish translations for this to Transifex yet? If not, please make sure you do that, and then merge all this in and send it over to Acceptance IMO! 😄

@enyia21 enyia21 temporarily deployed to il-gcc-ccap-510-update--ic522x December 17, 2024 15:38 Inactive
@enyia21
Copy link
Contributor Author

enyia21 commented Dec 17, 2024

@cram-cfa. I have not added the changes to transifex. I didn't realize that we were adding the translations to transifex when copy changes were being made

@cram-cfa
Copy link
Contributor

@cram-cfa. I have not added the changes to transifex. I didn't realize that we were adding the translations to transifex when copy changes were being made

Yeah, we're supposed to be adding the Spanish translations in the PR branch that is opened in Transifex. That's what we agreed upon with Carl and Carlie. From this "branch" in Transifex:

Screenshot 2024-12-17 at 9 56 09 AM

https://app.transifex.com/code-for-america-1/snil-il-get-childcare/translate/#es/e7ba367327a50c66a9c93f16086f51d3/566791769?q=translated%3Ano should be all you need to update.

…P-510-Update-homepage-notice-Existing-providers (#934)

Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-510-update--ic522x December 17, 2024 18:14 Inactive
@enyia21 enyia21 merged commit 46eeda8 into main Dec 17, 2024
5 checks passed
@enyia21 enyia21 deleted the CCAP-510-Update-homepage-notice-Existing-providers branch December 17, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants