Skip to content

[FYST-1946] NC: implement out of country extension question + pdf/xml #5859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 4, 2025
Merged

[FYST-1946] NC: implement out of country extension question + pdf/xml #5859

merged 10 commits into from
Apr 4, 2025

Conversation

@arinchoi03
Copy link
Contributor

@arinchoi03 arinchoi03 commented Apr 2, 2025 •
edited
Loading

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Add a new question, populate relevant fields in NC xml/pdf

How to test?

  • Describe the testing approach taken to verify the changes, including:
    • Unit/integration/manual tests
    • Test data used: any, just set the flipper for extension_period on heroku env
  • After
Screenshot 2025-04-02 at 12 16 13 PM Screenshot 2025-04-02 at 12 34 13 PM Screenshot 2025-04-02 at 12 35 52 PM

@github-actions
Copy link

github-actions bot commented Apr 2, 2025

Heroku app: https://gyr-review-app-5859-1b4d2021bb0d.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5859 (optionally add --tail)

@arinchoi03 arinchoi03 marked this pull request as ready for review April 2, 2025 19:43
mpidcock
mpidcock approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@mpidcock mpidcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may have added the flipper flag in more places than necessary, but I'm curious if others have thoughts so I added it to standup Qs. (not a blocker in any case)

config/locales/en.yml Outdated
title: First, let's see if you can use this service to file your %{filing_year} North Carolina taxes
nc_out_of_country:
edit:
title: Were you out of the country on April 15, 2025 and a US citizen or resident?
Copy link
Member

@mpidcock mpidcock Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the future is uncertain, but I don't want to be hardcoding filing years

Copy link
Contributor Author

@arinchoi03 arinchoi03 Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh good point

@arinchoi03
Copy link
Contributor Author

arinchoi03 commented Apr 3, 2025 •
edited
Loading

I think you may have added the flipper flag in more places than necessary, but I'm curious if others have thoughts so I added it to standup Qs. (not a blocker in any case)

I added the flipper check in the pdf belatedly after seeing this pattern in the AZ pdf, and did briefly wonder about it (ultimately thought it's fine to be redundant just to be safe). Happy to not do that in the pdf, dont feel too strongly about it either way

@arinchoi03 arinchoi03 merged commit 86590a4 into main Apr 4, 2025
7 checks passed
@arinchoi03 arinchoi03 deleted the FYST-1946-nc-implement-nc-out-of-country-extension-question-pdf-xml branch April 4, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpidcock mpidcock mpidcock approved these changes

Assignees

No one assigned

Labels

in-acceptance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arinchoi03 @mpidcock