NJ 316 - accessibility SC412 back arrow is read aloud #5869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-5869-1fb638f2cde3.herokuapp.com/ |
mluedke2
reviewed
Apr 4, 2025
| a { | ||
| &:before { | ||
| content:'←'; | ||
| content:'←' / ''; |
Contributor
There was a problem hiding this comment.
[dust] - this syntax is new to me, and is cool! looked it up and here is a link in case anyone is interested:
mluedke2
approved these changes
Apr 4, 2025
tahsinaislam
approved these changes
Apr 4, 2025
jachan
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
newjersey/accessibility-pm#16
Is PM acceptance required? (delete one)
What was done?
Add empty alt text to left-arrow pseudo-element on back button, so that it is flagged as decorative content and not read aloud by screen readers
How to test?
use voiceover or similar
Screenshots (use audio)
BEFORE:
Screen.Recording.2025-04-03.at.13.59.19.mov
AFTER:
Screen.Recording.2025-04-04.at.10.38.57.mov