-
Notifications
You must be signed in to change notification settings - Fork 13
Fyst 2266 update fyst pya homepage fileyourstatetaxes org after sunset #6102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fyst 2266 update fyst pya homepage fileyourstatetaxes org after sunset #6102
Conversation
…tatetaxes-org-after-sunset
…tatetaxes-org-after-sunset
|
Heroku app: https://gyr-review-app-6102-bbf8492dcfa2.herokuapp.com/ |
| </p> | ||
| <p><%= t(".subheader_3_html", login_path: login_options_path) %></p> | ||
| </div> | ||
| <%= link_to "https://pya.fileyourstatetaxes.org/year_select#{I18n.locale == :en ? '' : I18n.locale}/", class: "button button--primary button--icon button--wide spacing-below-15 no-external", id: "firstCta", role: "button", style: "display: flex; justify-content: center; align-items: center; text-align: center;" do %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same non-blocking question as on codeforamerica/pya#202, "Why leave out locale if it's en? It seems like the url with /en/ in it works just fine."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, I guess I thought it looked better in the url bar shorter but I am happy to change it.
https://codeforamerica.atlassian.net/browse/FYST-2266
don't merge until JIRA issue is accepted!
updates the home page
make sure sunset fyst flipper tag is flipped to test
work is mirrored on pya here