GYR1-808 Allow multiple partners to serve clients in the same zip code #6110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahsinaislam
commented
Nov 19, 2025
| # | ||
| # index_vita_partner_zip_codes_on_vita_partner_id (vita_partner_id) | ||
| # index_vita_partner_zip_codes_on_zip_code (zip_code) UNIQUE | ||
| # index_vita_partner_zip_codes_on_zip_code (zip_code) |
Contributor
Author
There was a problem hiding this comment.
needed to take out unique constraint
|
Heroku app: https://gyr-review-app-6110-6085acb231a3.herokuapp.com/ |
tahsinaislam
commented
Nov 19, 2025
| expect(page).to have_css('.client-table') | ||
| expect(page).to have_css('.client-row', count: 4) | ||
|
|
||
| # Default sort order |
Contributor
Author
There was a problem hiding this comment.
this was a flaky test, added a wait condition to help things load first before checking the content
embarnard
reviewed
Nov 19, 2025
| it "creates a new vita partner zip code for this partner" do | ||
| expect { | ||
| post :create, params: params, format: :js, xhr: true | ||
| }.to change(vita_partner.serviced_zip_codes, :count).by 1 |
Contributor
There was a problem hiding this comment.
what is format: :js, xhr: true doing in this context?
Contributor
Author
There was a problem hiding this comment.
had to look this up because i copied it from the rest of existing tests, but I think its to retrieve data from a URL without a fill page refresh
embarnard
approved these changes
Nov 19, 2025
tahsinaislam
deleted the
GYR1-808-allow-multiple-partners-to-serve-clients-in-the-same-zip-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
Is PM acceptance required?
What was done?
How to test?