Fix for SQL syntax checker crash due to invalid statement #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: worksofliam <[email protected]>
|
👋 A new build is available for this PR based on bd22cb7. |
Signed-off-by: worksofliam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for the component library to be blank due to the nature of how components are cached.
If a component is being checked (first time connection, connect and reload), then the library was being fetched correctly. But, if reconnecting, VS Code assumes the state of the last time it connected (so likely installed) and wasn't getting the install library.
This now gets fetches the library when validating a statement if the library is not set, therefore fixing the broken statement.