Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing props to explicit check in tests #1819

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

worksofliam
Copy link
Contributor

Changes

Existing tests were missing props added by previous API changes.

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@chrjorgensen chrjorgensen self-requested a review February 1, 2024 22:53
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@worksofliam I can confirm that the following tests fail in master:

image

After applying this change, the tests completes without errors.

@sebjulliand sebjulliand merged commit d8cc886 into master Feb 2, 2024
1 check passed
@sebjulliand sebjulliand deleted the fix/tests_missing_new_prop branch February 2, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants