Display more explicit error message when connection fails #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seb Julliand <[email protected]>
chrjorgensen
requested changes
Feb 2, 2024
There was a problem hiding this comment.
@sebjulliand Nice PR - works as expected. 👍
Only a small comment...
chrjorgensen
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
@sebjulliand Okay - approved, merge when you feel for it... 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR makes the connection failure messages more explicit, depending on the error.
There are three error cases for which we provide an explicit message:
If the error case cannot be determined from the error returned by SSH, then the error is displayed as it used to be.
Example of the three possible messages:
