Fix/no_member_validation

[worksofliam]

Changes

Removes additional check to find out if the chosen member exists. There are two reasons why I think this is allowed:

1. Because if the user enters a path manually, we can assume it does exist. Even if it doesn't exist, the tab will open with a valid error saying the member cannot be found. Fine by me.
2. If the user is using the ability to search with the asterisk filter, then we already know that the member exists.
3. Turns out, on systems with a huge member count this statement was taking a long time to run. That is a problem.

Checklist

• have tested my change
• updated relevant documentation
• Remove any/all console.logs I added
• eslint is not complaining
• have added myself to the contributors' list in CONTRIBUTING.md
• for feature PRs: PR only includes one feature enhancement.

[chrjorgensen]

@worksofliam The code is in there for a reason: The member extension is not part of the member identification, so the user can enter member.clle and get the source from member.sqlrpgle if not verified - the current code verifies that the extension is correct, so the user will get an error message if it is not the case = better UX.

SQL is not very good at retrieving info about specific members - it lists all info about all members before it selects the one requested. Thus the slower experience...

Can I have a go at this? I have some ideas of how we could retrieve member information much faster than this...

[worksofliam]

@chrjorgensen Yes! Be my guest. Perhaps it is also an option to use our checkObject API which has a member attribute now?

[chrjorgensen]

@worksofliam Unfortunately the checkObjectAPI does not support member extension (uses CHKOBJ behind the scenes), and the member extension is the problem here... but I have other ideas, stay tuned... 😃

[chrjorgensen]

@worksofliam New solution is ready - but not using your commits. Should I put it in another PR?

[chrjorgensen]

PR closed, replaced by #1867.