Connection browser enhancements #1845
Conversation
src/locale/ids/fr.ts
Outdated
| @@ -45,6 +45,9 @@ export const fr: Locale = { | |||
| 'connectionBrowser.connectTo.lastUsed': `Dernière utilisation: {0}`, | |||
| 'connectionBrowser.connectTo.title': `Dernières connexions IBM i`, | |||
| 'connectionBrowser.connectTo.error': `Utilisez l'Explorateur de Serveur pour sélectionner le serveur auquel se connecter.`, | |||
| 'connectionBrowser.renameConnection.prompt': `Rename connection {0}`, | |||
There was a problem hiding this comment.
@sebjulliand Could I ask you to translate these three new texts into French? 🙏
|
Not part of my review but an issue nonetheless: If I rename a connection, enter a new name, and get this error: 
But then if I refresh the view, the name is updated correctly. |
|
@worksofliam Could your error be caused by some "molested" configuration settings in VS Code, where the I've seen many examples of this in my own settings - like the A connection has values in up to four different places in the settings / storage, and currently there is a danger in the code, that only part of them gets the new name for the connection. So be careful when testing - do not test on important connections! I will add a try-catch block to catch any errors and not update anything if errors occurred - stay tuned... |
|
@worksofliam Error handling has been added and you should get more error information - and not get any connection changed if error occurred. (Tested this with @sebjulliand Now even more messages to translate to French... 😉 |
src/locale/ids/fr.ts
Outdated
| @@ -45,6 +45,9 @@ export const fr: Locale = { | |||
| 'connectionBrowser.connectTo.lastUsed': `Dernière utilisation: {0}`, | |||
| 'connectionBrowser.connectTo.title': `Dernières connexions IBM i`, | |||
| 'connectionBrowser.connectTo.error': `Utilisez l'Explorateur de Serveur pour sélectionner le serveur auquel se connecter.`, | |||
| 'connectionBrowser.renameConnection.prompt': `Rename connection {0}`, | |||
Co-authored-by: Sébastien Julliand <[email protected]>
Co-authored-by: Sébastien Julliand <[email protected]>
Co-authored-by: Sébastien Julliand <[email protected]>
Changes
This PR adds some enhancements to the server browser:
Checklist
console.logs I added