-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add object commands to sourcefiles in Object browser #1852
Add object commands to sourcefiles in Object browser #1852
Conversation
I made another ligther solution for the object browser, after some advice from @sebjulliand ... 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine!
Now, since the interface SourcePhysicalFileItem
is strictly identical to ObjectItem
, it may be better to remove it and let ObjectBrowserSourcePhysicalFileItem
implements ObjectItem
instead. It would make more sense than having a duplicated interface (and it's just logical since a source physical file IS an Object).
What do you think?
5b4b11c
to
b903bf8
Compare
Will you do a final review? |
@chrjorgensen I checked out this branch but I am getting these reference errors which is not letting me build! ![]() |
d7d3b7e
to
b903bf8
Compare
b903bf8
to
5856139
Compare
@worksofliam How about now? I force-pushed my local branch after rebasing on newest master branch and fixing conflicts... 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. I am able to use typically object context items on source files now!
Changes
This is a PR to add the object commands, like
Change Object Description
, to sourcefiles as well:Please comment on this - if it's a bad idea or whatever you think. 🥲
Checklist