Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object commands to sourcefiles in Object browser #1852

Conversation

chrjorgensen
Copy link
Collaborator

@chrjorgensen chrjorgensen commented Feb 18, 2024

Changes

This is a PR to add the object commands, like Change Object Description, to sourcefiles as well:

image

Please comment on this - if it's a bad idea or whatever you think. 🥲

Checklist

  • have tested my change
  • for feature PRs: PR only includes one feature enhancement.

@chrjorgensen chrjorgensen added the enhancement New feature or request label Feb 18, 2024
@chrjorgensen chrjorgensen requested a review from a team February 18, 2024 16:20
@chrjorgensen chrjorgensen self-assigned this Feb 18, 2024
@chrjorgensen chrjorgensen changed the title Add object commands to sourcefiles in Object browser DRAFT: Add object commands to sourcefiles in Object browser Feb 18, 2024
@chrjorgensen
Copy link
Collaborator Author

I made another ligther solution for the object browser, after some advice from @sebjulliand ... 🙏

@chrjorgensen chrjorgensen changed the title DRAFT: Add object commands to sourcefiles in Object browser Add object commands to sourcefiles in Object browser Feb 18, 2024
@chrjorgensen chrjorgensen marked this pull request as ready for review February 18, 2024 20:02
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine!
Now, since the interface SourcePhysicalFileItem is strictly identical to ObjectItem, it may be better to remove it and let ObjectBrowserSourcePhysicalFileItem implements ObjectItem instead. It would make more sense than having a duplicated interface (and it's just logical since a source physical file IS an Object).
What do you think?

@chrjorgensen chrjorgensen force-pushed the feature/add-object-commands-to-sourcefiles branch from 5b4b11c to b903bf8 Compare February 22, 2024 08:10
@chrjorgensen
Copy link
Collaborator Author

@sebjulliand

  • I removed SourcePhysicalFileItem as you suggested.
  • I also fixed Run Action for sourcefiles - had to set the resourceUri on the browser item.
  • I also cleaned up my mess - again...! 😄

Will you do a final review?

@worksofliam worksofliam added this to the 2.7.1 milestone Feb 22, 2024
@worksofliam
Copy link
Contributor

@chrjorgensen I checked out this branch but I am getting these reference errors which is not letting me build!

image

@chrjorgensen chrjorgensen force-pushed the feature/add-object-commands-to-sourcefiles branch from d7d3b7e to b903bf8 Compare February 22, 2024 16:25
@chrjorgensen chrjorgensen force-pushed the feature/add-object-commands-to-sourcefiles branch from b903bf8 to 5856139 Compare February 22, 2024 16:35
@chrjorgensen
Copy link
Collaborator Author

@worksofliam How about now? I force-pushed my local branch after rebasing on newest master branch and fixing conflicts... 🙏

Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. I am able to use typically object context items on source files now!

@chrjorgensen chrjorgensen merged commit b22f840 into codefori:master Feb 23, 2024
1 check passed
@worksofliam
Copy link
Contributor

Just retested and it's looking good!!

image

@chrjorgensen chrjorgensen deleted the feature/add-object-commands-to-sourcefiles branch March 20, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants