Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip for objects in object browser #1872

Merged

Conversation

chrjorgensen
Copy link
Collaborator

Changes

This PR is a continuation of the tooltips changes - it adds a tooltip to objects in the object browser, when the object is not a source file:

image

Checklist

  • have tested my change

@chrjorgensen chrjorgensen requested a review from a team February 23, 2024 20:48
@chrjorgensen chrjorgensen self-assigned this Feb 23, 2024
@chrjorgensen chrjorgensen added the enhancement New feature or request label Feb 23, 2024
@chrjorgensen chrjorgensen added this to the 2.8.0 milestone Feb 23, 2024
Comment on lines 33 to 35
'type': 'Type',
'attribute': 'Attribute',
'created_by': 'Created by',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand We need your translation skills here! 😉

Co-authored-by: Sébastien Julliand <[email protected]>
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested over a few different objects and it works like a charm.
A fine addition! I guess we have big enough tooltips now 😅

I'll approve and let you merge whenever you want, if you'd like others to review too. But I'm fine with it!

@chrjorgensen
Copy link
Collaborator Author

@sebjulliand

I guess we have big enough tooltips now 😅

I remember someone recently telling me "we can't have enough information"... 😉

Just kidding - I agree and had to think about when deciding which information to include. We really need that FS extension...! 😍

@chrjorgensen chrjorgensen merged commit 725454f into codefori:master Feb 24, 2024
1 check passed
@chrjorgensen chrjorgensen deleted the feature/add-object-tooltips branch March 20, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants