Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show context sensitive commands in Command Palette #1906

Merged

Conversation

chrjorgensen
Copy link
Collaborator

Changes

This PR will stop Command Palette from showing IBM i commands, which are context sensitive and should not be available as a command:

  • IBM i: New Connection is only available when not connected (when connected it would disconnect the current connection without warning)
  • the following commands are removed:
    IBM i: Login Settings
    IBM i: Close (search view)
    IBM i: Collapse All (search view)
    IBM i: Debug Program
    IBM i: Delete... (in object browser)
    IBM i: Select for Compare
    IBM i: Change... (filter)
    IBM i: Sort Filters
    IBM i: Move Up (filter)
    IBM i: Move Down (filter)
    IBM i: Sort Shortcuts
    IBM i: Upload... (streamfile)
    IBM i: Move Up (library)
    IBM i: Move Down (library)
    IBM i: Remove from Library List
    IBM i: Refresh (library list view)
    IBM i: Refresh (member browser)
    IBM i: Refresh (IFS browser item)
    IBM i: Refresh (object browser view)

Checklist

  • have tested my change

@chrjorgensen chrjorgensen added the bug A confirmed issue when something isn't working as intended label Mar 4, 2024
@chrjorgensen chrjorgensen requested a review from a team March 4, 2024 12:40
@chrjorgensen chrjorgensen self-assigned this Mar 4, 2024
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for it! Merge at will!

@chrjorgensen chrjorgensen merged commit ffa4592 into codefori:master Mar 4, 2024
1 check passed
@chrjorgensen chrjorgensen deleted the fix/ibmi-command-palette branch March 4, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants