Correctly handle source members with variant characters in their name

[sebjulliand]

Changes

Fixes #1935

Member names used to be uppercased regarless of the variant characters they may contain. Turns out that à is one of CCSID 297 (French) variant chars and it gets uppercased to À, which raises a member not found error.

This PR adds a new upperCaseName method to the IBMi class to correctly uppercase names, preservingthe variant chars case.

How to test this PR

1. Set PASE_LANG environment variable to FR_FR
2. Open a connection with a profile whose CCSID is 297
3. Try to open a member with one or more à in its name

Checklist

• have tested my change
• have created one or more test cases

[chrjorgensen]

@sebjulliand I gave the PR a spin, but had no success... 😞

With or without SQL enabled, when I tried to open a member having à in the name, I got the following error:

The member name is correct in the list:

???

Does it work at your end? Could be my system setup...

[sebjulliand]

@chrjorgensen check out my comment here: #1935 (comment)

I'll add a commit to this PR with the copy to a temporary member (I managed to open the member, I just need to apply the same logic when saving). We'll see how it goes (I'll un-draft the PR then).

[sebjulliand]

@chrjorgensen you can give it another try; I managed to open and save my member with a à using this patch.

[chrjorgensen]

@sebjulliand I have not tried your workaround yet - but when I look at the code, it seems you're copying to temporary member in case of any variant characters in the name. Which would mean most non-US users will be hit by this workaround, even though they've had no problems so far. Correct?

If correct, wouldn't it be better to only do the workaround if they would have been hit by the à problem? By testing for change when uppercasing the variants:

if ( this.ibmi.variantChars.local !== this.ibmi.variantChars.local.toLocaleUpperCase() ) {

That way we run as before for the majority of the users - no change for them... What do you think?

[sebjulliand]

@chrjorgensen you're right, let's reduce the scope only to those who use dangerous variants 😅

[sebjulliand]

@chrjorgensen there you go

[chrjorgensen]

@sebjulliand I can confirm being able to open and edit and save members having à in the member name when I simulate being French (CCSID 297 etc) when running your PR. 👍

Approved - merge at will... 😃

[sebjulliand]

Thank you @chrjorgensen !