Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed quick filter creation for listing libraries #1945

Merged
merged 8 commits into from
Mar 20, 2024
Merged

Conversation

sebjulliand
Copy link
Collaborator

Changes

This PR fixes the filters using the Create Quick Filter... action that would create a filter with wrong values for listing libraries.

How to test this PR

  1. Create a quick filter with value Q*
  2. It must lists all the libraries starting with Q when expanded

Checklist

  • have tested my change

@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label Mar 19, 2024
@sebjulliand sebjulliand self-assigned this Mar 19, 2024
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand Last review before bedtime:

There are some calls to toUppercase() in createQuickFilter - shouldn't these be changed to your uppercase routine?

@worksofliam
Copy link
Contributor

@chrjorgensen is right about his suggested. Nonetheless, the fix works:

image

@chrjorgensen chrjorgensen self-requested a review March 20, 2024 07:09
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand So far my tests are positive. 👍

But I'm having difficulties testing this PR with CCSID 297 - could you rebase it on master or merge master branch into this PR, so I can run the final tests?

@sebjulliand
Copy link
Collaborator Author

@sebjulliand So far my tests are positive. 👍

But I'm having difficulties testing this PR with CCSID 297 - could you rebase it on master or merge master branch into this PR, so I can run the final tests?

And done! 🙌🏻

Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand Quick Filter works fine now, including in CCSID 297. 👍

I've fixed an error showing invalid member when a member was selected from recent files and having variants in the name.

Approved and merged. 🚀

@chrjorgensen chrjorgensen merged commit c522a58 into master Mar 20, 2024
1 check passed
@sebjulliand
Copy link
Collaborator Author

Brilliant @chrjorgensen , thank you!

@sebjulliand sebjulliand deleted the fix/quickFilter branch March 22, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants