-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed quick filter creation for listing libraries #1945
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebjulliand Last review before bedtime:
There are some calls to toUppercase()
in createQuickFilter
- shouldn't these be changed to your uppercase routine?
@chrjorgensen is right about his suggested. Nonetheless, the fix works: ![]() |
Signed-off-by: Seb Julliand <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebjulliand So far my tests are positive. 👍
But I'm having difficulties testing this PR with CCSID 297 - could you rebase it on master or merge master branch into this PR, so I can run the final tests?
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
And done! 🙌🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebjulliand Quick Filter works fine now, including in CCSID 297. 👍
I've fixed an error showing invalid member when a member was selected from recent files and having variants in the name.
Approved and merged. 🚀
Brilliant @chrjorgensen , thank you! |
Changes
This PR fixes the filters using the
Create Quick Filter...
action that would create a filter with wrong values for listing libraries.How to test this PR
Q*
Checklist