Fix member and object resolve with variants #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrjorgensen
added
the
bug
|
@chrjorgensen What's the state of this PR? It is assigned to you, but is it ready for review? |
|
@worksofliam Yes, ready for review since I requested a review from you and Seb... 😉😘 |
|
Code looks good and your new + previous tests are still passing. I also used your step to test the copy book and it's looking good to me. Let's merge for 2.9.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes resolving members and objects having variant characters in their name.
Tests have been added to verify member and object resolve with variant characters.
Before this would not work:
After this fix the member resolution now works:
How to test this PR
Alt-F12with the cursor in the referenced member name.Checklist