Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change library validation logic #1969

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Change library validation logic #1969

merged 2 commits into from
Apr 4, 2024

Conversation

worksofliam
Copy link
Contributor

Changes

Fixes #1879. Prior to this PR, we were checking invalid libraries by looking for a text string that was specific to EN. That meant validateLibraryList did not work for non EN languages.

How to test this PR

  1. Run the test cases (we have a test case for validateLibraryList)
  2. Add non existing libraries to the user library list and expect a warning that it does not exist
    • Specifically trying this on multiple different locales

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

@worksofliam worksofliam requested a review from sebjulliand April 3, 2024 13:24
@worksofliam worksofliam added this to the 2.9.0 milestone Apr 3, 2024
@sebjulliand
Added brackets
f3bd7c3 
Signed-off-by: Seb Julliand <[email protected]>
sebjulliand
sebjulliand approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Tested with various libraries, including one with the à variant. Let's merge!

@sebjulliand sebjulliand merged commit 8dc66ba into master Apr 4, 2024
1 check passed
@sebjulliand sebjulliand deleted the fix/invalid_library_checker branch April 4, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebjulliand sebjulliand sebjulliand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

Non-existent libraries are added to the user library list
2 participants
@worksofliam @sebjulliand