Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/debug_version_path #1996

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Fix/debug_version_path #1996

merged 2 commits into from
Apr 20, 2024

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Apr 19, 2024 •
edited
Loading

Luckily no major problems because SEP isn't out yet.

Changes

  • Start batch debug was missing from the active editor
  • When starting the debug service, it was failing to get the correct Java version because it was testing for file existing against the wrong variable.

How to test this PR

Examples:

  1. Run the test cases
  2. Ensure the debug service starts up
  3. Can batch debug from the Object Browser and the active editor

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

@worksofliam worksofliam requested a review from sebjulliand April 19, 2024 14:59
@worksofliam worksofliam added the bug A confirmed issue when something isn't working as intended label Apr 19, 2024
@worksofliam worksofliam added this to the 2.10.0 milestone Apr 19, 2024
@worksofliam worksofliam linked an issue Apr 19, 2024 that may be closed by this pull request
Stop debug service does not work with v2 debug service #1998
Closed
sebjulliand
sebjulliand approved these changes Apr 20, 2024
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @worksofliam.

@sebjulliand sebjulliand merged commit 87ce474 into master Apr 20, 2024
1 check passed
@sebjulliand sebjulliand deleted the fix/debug_version_path branch April 20, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebjulliand sebjulliand sebjulliand approved these changes

Assignees
No one assigned
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

Stop debug service does not work with v2 debug service
2 participants
@worksofliam @sebjulliand