Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix No default deployment method not properly set #2399

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Fix No default deployment method not properly set #2399

merged 2 commits into from
Dec 4, 2024

Conversation

SanjulaGanepola
Copy link
Member

Changes

Fixes #2398

How to test this PR

Examples:

  1. Set Default Deployment Method to No Default
  2. You should be prompted for deployment method without error.

Checklist

  • have tested my change

@SanjulaGanepola SanjulaGanepola mentioned this pull request Dec 4, 2024
Closed
worksofliam
worksofliam approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead simple. Thank you!

worksofliam
worksofliam requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a break in this case for consistency?

@SanjulaGanepola
Add missing break
839c626 
Signed-off-by: Sanjula Ganepola <[email protected]>
worksofliam
worksofliam approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Thank you!

@worksofliam worksofliam merged commit c245547 into codefori:master Dec 4, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worksofliam worksofliam worksofliam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning message: "Default deployment method is set but not usable in your environment."
2 participants
@SanjulaGanepola @worksofliam