Refactor component management and add state caching #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for improved readability and maintainability Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
worksofliam
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
|
👋 A new build is available for this PR based on 0c03388. |
worksofliam
requested review from
sebjulliand and
SanjulaGanepola
and removed request for
sebjulliand
Signed-off-by: worksofliam <[email protected]>
worksofliam
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
|
Signed-off-by: worksofliam <[email protected]>
worksofliam
had a problem deploying
to
testing_environment
GitHub Actions
Failure
Co-authored-by: Sanjula Ganepola <[email protected]>
worksofliam
had a problem deploying
to
testing_environment
GitHub Actions
Failure
|
@SanjulaGanepola I followed through with your recommendations. I need to fix the test cases before you review. (I love automated test cases!!) |
Signed-off-by: worksofliam <[email protected]>
worksofliam
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
|
@SanjulaGanepola This PR is now ready for review again. The tests are correctly passing after I added a missing await. |
SanjulaGanepola
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve code readability and maintainability by refactoring library and directory checks into separate methods. Introduce caching for component states to enhance connection performance.
Adds the component stats to the settings cache and validation each one individually. This will allow us to update one component without updating them all again.
Before:
After: