Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add removed APIs from IBMi class #2504

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Add removed APIs from IBMi class #2504

merged 1 commit into from
Feb 5, 2025

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Feb 5, 2025

Deprecate the upload and download methods in the IBMi class, recommending the use of alternative methods for file operations.

This was needed as 2.14.5 has these APIs, and we can't remove them until 3.0.0.

Without this PR, the Db2 for i extension will break in the next release.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

👋 A new build is available for this PR based on 5e13737.

Copy link
Member

@SanjulaGanepola SanjulaGanepola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worksofliam worksofliam merged commit c0615e5 into master Feb 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants