Skip to content

Refactor component handling and improve user input management#2525

Merged
worksofliam merged 9 commits into
masterfrom
fixes/get_members
Feb 24, 2025
Merged

Refactor component handling and improve user input management#2525
worksofliam merged 9 commits into
masterfrom
fixes/get_members

Conversation

@worksofliam
Copy link
Copy Markdown
Member

@worksofliam worksofliam commented Feb 21, 2025 •
edited
Loading

  • move enableSQL to the connection instance.
  • enhance component manager checks for NotChecked state
    • Add missing away that was setting all cached states to NotChecked
  • handle potential crashes when the getMemberInfo component is unavailable.
  • fixed broken test introduced by another PR (where a date should have been returned correctly)

How to test

  1. Ensure Go to File works as expected for opening members:
    • Try entering QSYSINC/* to filter
    • Then try QSYSINC/H/*` to filter
    • Try opening MATH

@worksofliam
enableSQL does not exist on config, and was moved to connection
4d3f082 
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam
Make sure component manager is checking the component if the stored s…
27aa437 
…tate is NotChecked

Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam
Disable the Go to File user input when busy
827d05e 
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam
If getMemberInfo component is not available, handle crash
069aaaa 
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam worksofliam added the bug A confirmed issue when something isn't working as intended label Feb 21, 2025
@worksofliam worksofliam requested review from SanjulaGanepola and sebjulliand and removed request for SanjulaGanepola February 21, 2025 04:05
@worksofliam worksofliam linked an issue Feb 21, 2025 that may be closed by this pull request
Sometimes GetMemberInfo throws an SQL error #2524
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 21, 2025 •
edited
Loading

👋 A new build is available for this PR based on 14b2b0c.

@worksofliam worksofliam temporarily deployed to testing_environment February 21, 2025 14:47 — with GitHub Actions Inactive
@worksofliam worksofliam mentioned this pull request Feb 21, 2025
Merged
@worksofliam worksofliam requested a review from julesyan February 21, 2025 18:27
@worksofliam
Fix to date types not being returned
9ce6d45 
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam
Add timeouts to existing tests
ea3ce68 
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam worksofliam temporarily deployed to testing_environment February 21, 2025 18:55 — with GitHub Actions Inactive
@worksofliam
Add missing await to override state
7279669 
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam worksofliam temporarily deployed to testing_environment February 21, 2025 19:50 — with GitHub Actions Inactive
chrjorgensen
chrjorgensen reviewed Feb 21, 2025
View reviewed changes
Comment thread src/api/components/getMemberInfo.ts
@worksofliam worksofliam mentioned this pull request Feb 21, 2025
Merged
2 tasks
SanjulaGanepola
SanjulaGanepola requested changes Feb 24, 2025
View reviewed changes
Comment thread src/commands/open.ts Outdated
@worksofliam
Remove logic to handle busy state
14b2b0c 
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam worksofliam temporarily deployed to testing_environment February 24, 2025 17:55 — with GitHub Actions Inactive
chrjorgensen
chrjorgensen approved these changes Feb 24, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@worksofliam Code changes for Go To file tested and approved. 👍

Biggest issue during testing was that GetMbrInfo test failed - seems like the test creates a new, temp config for the host running the test? None of my connection profiles for that host uses the default temp library, so the function and the test sourcefile was not in the expected library. Something to be aware of!

@worksofliam
Copy link
Copy Markdown
Member Author

worksofliam commented Feb 24, 2025

@chrjorgensen Thanks!!

odd about your tests not passing. I recommend deleting the .json files under the tests folder and then trying running your tests against.

image

@worksofliam worksofliam merged commit c4878b9 into master Feb 24, 2025
@sebjulliand sebjulliand deleted the fixes/get_members branch October 23, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrjorgensen chrjorgensen chrjorgensen approved these changes

@sebjulliand sebjulliand Awaiting requested review from sebjulliand

@julesyan julesyan Awaiting requested review from julesyan

@SanjulaGanepola SanjulaGanepola Awaiting requested review from SanjulaGanepola

Assignees

No one assigned

Labels

bug A confirmed issue when something isn't working as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sometimes GetMemberInfo throws an SQL error

3 participants

@worksofliam @chrjorgensen @SanjulaGanepola