-
Notifications
You must be signed in to change notification settings - Fork 24
Add RPGUnit test case and test suite generation #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add RPGUnit test case and test suite generation #382
Conversation
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: Sanjula Ganepola <[email protected]>
Signed-off-by: Sanjula Ganepola <[email protected]>
Signed-off-by: Sanjula Ganepola <[email protected]>
Signed-off-by: Sanjula Ganepola <[email protected]>
Liam to move |
Signed-off-by: Sanjula Ganepola <[email protected]>
Signed-off-by: Sanjula Ganepola <[email protected]>
Signed-off-by: Sanjula Ganepola <[email protected]>
Signed-off-by: worksofliam <[email protected]>
…julaGanepola/vscode-rpgle into pr/SanjulaGanepola/382
Signed-off-by: Sanjula Ganepola <[email protected]>
Signed-off-by: worksofliam <[email protected]>
erge branch 'feature/rpgunit-test-case-generation' of https://github.com/SanjulaGanepola/vscode-rpgle into feature/rpgunit-test-case-generation
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: Sanjula Ganepola <[email protected]>
Signed-off-by: Sanjula Ganepola <[email protected]>
Signed-off-by: Sanjula Ganepola <[email protected]>
Got it working with most of the common types. Generates a test that passes! I'm going to add a bunch of new tests to verify all the APIs I added here work properly. I will do this outside this PR so we can at least still get this in. This is ready for review. Could we get a release out once it is merged? |
@SanjulaGanepola I am looking but |
Signed-off-by: Sanjula Ganepola <[email protected]>
@worksofliam Conflicts gone. Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really a simple change. I would like this to generate POSIX paths with single quotes around it.
...prototypes, | ||
``, | ||
`/include qinclude,TESTCASE`, | ||
...uniqueIncludes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some logic needs to happen for uniqueIncludes
.
If uniqueInclude
is a POSIX path (IFS/local), then please use single quotes around the /copy
//include
path:
/include 'qrpgleref/empdet.rpgleinc'
And to confirm, members should use this format:
/include qrpgleref,empdet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I update the PR to add single quotes. In general, test case generation for members and even IFS files won't work yet given how the file creation is currently implemented. Thus, I haven't made the change to fix the includes for members. I added it to this TODO list (#383) so I can make that change outside this PR.
@SanjulaGanepola Just additional non-requirement for this PR: there are a lot of new functions for this test action in |
Signed-off-by: Sanjula Ganepola <[email protected]>
@worksofliam Yes I agree. Added to the TODO list! |
Changes
Add RPGUnit test case and test suite generation
TODO:
Checklist