feat: Add ability to set nodePort on internal-router service #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Recreated PR as I didn't start my branch with |
mikhail-klimko
approved these changes
Dec 2, 2024
|
/e2e |
2 similar comments
|
/e2e |
|
/e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I have discovered a relatively easy way to run a gitops runtime in a local Kind cluster against a local (dev) instance of codefresh running in docker. The only thing missing from the existing helm chart is the ability to set the
nodePortvalue on theinternal-routerservice. Note: You can already set the service type toNodePortbut you just can't specify the nodePort that it uses, which we need to for my setup.Why
There has been some instability with the use of vclusters and so we're trying to find a way to run a local dev setup against a local cluster with a runtime. I believe I have found a solution that works quite well.
Notes
Old PR: #347