Skip to content

feat: rollout-reporter with external argo rollouts #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: rollout-reporter with external argo rollouts #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/gitops-runtime/templates/_components/event-reporters/rollout-reporter/_rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ kind: RoleBinding
metadata:
name: rollout-reporter-sa
labels:
app.kubernetes.io/part-of: workflow-reporter
app.kubernetes.io/part-of: rollout-reporter
codefresh.io/internal: "true"
roleRef:
apiGroup: ""
Expand All @@ -28,4 +28,4 @@ roleRef:
subjects:
- kind: ServiceAccount
name: {{ include "event-reporters.rollout-reporter.serviceAccountName" . }}
{{- end }}
{{- end }}
6 changes: 5 additions & 1 deletion charts/gitops-runtime/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,11 @@ Determine rollouts name
*/}}
{{- define "codefresh-gitops-runtime.argo-rollouts.name" -}}
{{/* For now use template from rollouts chart until better approach */}}
{{- template "argo-rollouts.fullname" (dict "Values" (get .Values "argo-rollouts")) }}
{{- if and (index .Values "argo-rollouts" "enabled") }}
{{- template "argo-rollouts.fullname" (dict "Values" (get .Values "argo-rollouts")) }}
{{- else }}
{{- printf "%s" (index .Values "event-reporters" "rollout" "external-argo-rollouts" "fullnameOverride") }}
{{- end }}
{{- end }}


Expand Down
4 changes: 2 additions & 2 deletions charts/gitops-runtime/templates/event-reporters/rollout-reporter/clusterrolebinding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{{/* Mapping of argo rollouts clusterrole if such is created (see https://github.com/codefresh-io/argo-helm/blob/argo-rollouts/charts/argo-rollouts/templates/controller/clusterrolebinding.yaml)
to the reporters ServiceAccount
*/}}
{{- if index (get .Values "argo-rollouts") "enabled" }}
{{- if and (index (get .Values "argo-rollouts") "clusterInstall") (index (get .Values "argo-rollouts") "controller" "createClusterRole") }}
{{- if or (index (get .Values "argo-rollouts") "enabled") (index .Values "event-reporters" "rollout" "external-argo-rollouts" "enabled") }}
{{- if or (and (index (get .Values "argo-rollouts") "clusterInstall") (index (get .Values "argo-rollouts") "controller" "createClusterRole")) (index .Values "event-reporters" "rollout" "external-argo-rollouts" "enabled") }}
{{- $eventReporterContext := deepCopy . }}
{{- $_ := set $eventReporterContext "Values" (deepCopy (get .Values "event-reporters")) }}
{{- $_ := set $eventReporterContext.Values "global" (deepCopy (get .Values "global")) }}
Expand Down
2 changes: 1 addition & 1 deletion charts/gitops-runtime/templates/event-reporters/rollout-reporter/eventsource.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if index (get .Values "argo-rollouts") "enabled" }}
{{- if or (index (get .Values "argo-rollouts") "enabled") (index .Values "event-reporters" "rollout" "external-argo-rollouts" "enabled") }}
{{- $eventReporterContext := deepCopy . }}
{{- $_ := set $eventReporterContext "Values" (deepCopy (get .Values "event-reporters")) }}
{{- $_ := set $eventReporterContext.Values "global" (deepCopy (get .Values "global")) }}
Expand Down
2 changes: 1 addition & 1 deletion charts/gitops-runtime/templates/event-reporters/rollout-reporter/rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if index (get .Values "argo-rollouts") "enabled" }}
{{- if or (index (get .Values "argo-rollouts") "enabled") (index .Values "event-reporters" "rollout" "external-argo-rollouts" "enabled") }}
{{- $eventReporterContext := deepCopy . }}
{{- $_ := set $eventReporterContext "Values" (deepCopy (get .Values "event-reporters")) }}
{{- $_ := set $eventReporterContext.Values "global" (deepCopy (get .Values "global")) }}
Expand Down
2 changes: 1 addition & 1 deletion charts/gitops-runtime/templates/event-reporters/rollout-reporter/sensor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if index (get .Values "argo-rollouts") "enabled" }}
{{- if or (index (get .Values "argo-rollouts") "enabled") (index .Values "event-reporters" "rollout" "external-argo-rollouts" "enabled") }}
{{- $eventReporterContext := deepCopy . }}
{{- $_ := set $eventReporterContext "Values" (deepCopy (get .Values "event-reporters")) }}
{{- $_ := set $eventReporterContext.Values "global" (deepCopy (get .Values "global")) }}
Expand Down
2 changes: 1 addition & 1 deletion charts/gitops-runtime/templates/event-reporters/rollout-reporter/serviceaccount.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if index (get .Values "argo-rollouts") "enabled" }}
{{- if or (index (get .Values "argo-rollouts") "enabled") (index .Values "event-reporters" "rollout" "external-argo-rollouts" "enabled") }}
{{- $eventReporterContext := deepCopy . }}
{{- $_ := set $eventReporterContext "Values" (deepCopy (get .Values "event-reporters")) }}
{{- $_ := set $eventReporterContext.Values "global" (deepCopy (get .Values "global")) }}
Expand Down
3 changes: 3 additions & 0 deletions charts/gitops-runtime/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,9 @@ argo-rollouts:
#-----------------------------------------------------------------------------------------------------------------------
event-reporters:
rollout:
external-argo-rollouts:
enabled: false
fullnameOverride: argo-rollouts
serviceAccount:
create: true
eventSource:
Expand Down