-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added JS Roadmap #2933
Added JS Roadmap #2933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @dhairyagothi! 🎉 Thank you for submitting your pull request to CodeHarborHub. We appreciate your contribution and enthusiasm! Our team will review it soon. If you have any questions or need further assistance, feel free to reach out. Thanks for contributing!
Here's the code health analysis summary for commits Analysis Summary
|
src/components/Roadmap/index.tsx
Outdated
{ id: 2, name: "CSS", link: "#" }, | ||
{ id: 3, name: "JavaScript", link: "#" }, | ||
{ id: 2, name: "CSS", link: "" }, | ||
{ id: 3, name: "JavaScript", link: "../database/Roadmap/Js" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not working Please tell changes to do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Navigate to the
pages/roadmap
directory and create a new file namedjavascript/index.tsx
. - Import the content from
database/Roadmap/Js
into this new file. - Write the code for the new JavaScript roadmap page in
javascript/index.tsx
. - Update the import path in
src/components/Roadmap/index.tsx
by replacing../database/Roadmap/Js
with/roadmap/javascript
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhairyagothi, change your code based on suggestions
added @ajay-dhangar |
@dhairyagothi, the current roadmap design needs improvement for better clarity and user experience. For inspiration and guidance, please refer to the UI/UX of roadmap.sh/javascript. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhairyagothi, Please focus on best practices when using CSS, especially since we are handling large amounts of content. It's important to use specific components and CSS rules, such as parent-child relationships, to ensure our styles are efficient and maintainable. Additionally, consider using tools like styled-components for better organization and scalability.
sure i am trying to make it as like you said |
@ajay-dhangar i want to ask that if i can make a figma design and later convert it into html css and adding it .tsx file then its okay ? |
Absolutely! Converting a Figma design into HTML/CSS and integrating it into a |
@dhairyagothi, I appreciate your willingness to help with my open source projects. However, please keep in mind that I want to respect your time, knowing you're actively contributing to multiple projects. Longer discussions might complicate things or create issues based on your PRs or contributions. |
Sure @ajay-dhangar i will make pr ASAP |
@ajay-dhangar please consider this for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the code based on the suggestions. Focus on enhancing the design and making data handling with props and mapping more efficient. For reference, you can visit https://github.com/CodeHarborHub/codeharborhub.github.io/tree/main/src/data/roadmaps. Create a JavaScript file there and add the relevant topics.
NOTE: you can write code only one file like
javascript/index.tsx
For Example
src/database/roadmap/css/index.tsx
type ResourceLink = {
url: string;
text: string;
};
type SubTopic = {
id: string;
title: string;
description: string;
links: ResourceLink[];
};
type Topic = {
id: number;
title: string;
content: SubTopic[];
};
const cssRoadmap: Topic[] = [
{
id: 1,
title: "Introduction to CSS",
content: [
{
id: "1.1",
title: "What is CSS?",
description: "Learn about the basics of CSS and its importance in web development.",
links: [
{ url: "https://developer.mozilla.org/en-US/docs/Learn/CSS/First_steps/What_is_CSS", text: "MDN Web Docs" },
{ url: "https://www.w3schools.com/css/css_intro.asp", text: "W3Schools Introduction to CSS" }
]
},
{
id: "1.2",
title: "CSS Syntax and Selectors",
description: "Understand the syntax of CSS and how to use selectors to style elements.",
links: [
{ url: "https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Selectors", text: "MDN CSS Selectors" },
{ url: "https://www.w3schools.com/css/css_syntax.asp", text: "W3Schools CSS Syntax" }
]
}
]
},
{
id: 2,
title: "CSS Fundamentals",
content: [
{
id: "2.1",
title: "Colors and Backgrounds",
description: "Learn how to apply colors and background styles to elements.",
links: [
{ url: "https://developer.mozilla.org/en-US/docs/Web/CSS/color", text: "MDN Colors" },
{ url: "https://www.w3schools.com/css/css_background.asp", text: "W3Schools Backgrounds" }
]
},
{
id: "2.2",
title: "Box Model",
description: "Understand the CSS box model and how it affects element layout.",
links: [
{ url: "https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Box_Model/Introduction_to_the_CSS_box_model", text: "MDN Box Model" },
{ url: "https://www.w3schools.com/css/css_boxmodel.asp", text: "W3Schools Box Model" }
]
}
]
},
{
id: 3,
title: "Advanced CSS",
content: [
{
id: "3.1",
title: "Flexbox",
description: "Learn about the Flexbox layout model and how to use it for responsive designs.",
links: [
{ url: "https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Flexible_Box_Layout", text: "MDN Flexbox" },
{ url: "https://www.w3schools.com/css/css3_flexbox.asp", text: "W3Schools Flexbox" }
]
},
{
id: "3.2",
title: "Grid",
description: "Understand CSS Grid and how it can be used to create complex layouts.",
links: [
{ url: "https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Grid_Layout", text: "MDN Grid" },
{ url: "https://www.w3schools.com/css/css_grid.asp", text: "W3Schools Grid" }
]
}
]
}
];
export default cssRoadmap;
@@ -0,0 +1,96 @@ | |||
body { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
body {
font-family: sans-serif;
background-color: #f4f4f4;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to read carefully #2933 (review) I shared alreade for css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for example you can check ou https://github.com/CodeHarborHub/codeharborhub.github.io/blob/main/src/components/Roadmap/Roadmap.css like this
Related Issue
Description
Added Javascript roadmap
[Please include a brief description of the changes or features added]
Type of PR
Screenshots / Videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist
Additional Context
[Include any additional information or context that might be helpful for reviewers.]
Resources for Guidance
Please read the following resources before submitting your contribution:
Resources for DSA Features on Our Site:
Contribution Guidelines
Thank you for considering contributing to our project! To ensure smooth collaboration and effective contribution management, please adhere to the following guidelines:
Issue Creation
Contribution Levels
Basic Contributions:
Acknowledging Hard Work:
Feature Additions and Component Work:
Level Definitions
We look forward to your contributions and appreciate your effort in helping us improve the project!