Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Fix phpstan method.unused #9388

Merged
merged 1 commit into from
Jan 10, 2025
Merged

refactor: Fix phpstan method.unused #9388

merged 1 commit into from
Jan 10, 2025

Conversation

neznaika0
Copy link
Contributor

Description
Just ignore line. Or should I leave similar errors in the .neon files?

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

paulbalandan
paulbalandan reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this fixture being used?

@paulbalandan paulbalandan added the testing Pull requests that changes tests only label Jan 9, 2025
@neznaika0
Copy link
Contributor Author

https://github.com/neznaika0/codeigniter-dev/blob/564b5b7e209de959e5b2965cff749fed82db8d0e/tests/system/Test/ReflectionHelperTest.php#L72
https://github.com/neznaika0/codeigniter-dev/blob/564b5b7e209de959e5b2965cff749fed82db8d0e/tests/system/Test/ReflectionHelperTest.php#L85

paulbalandan
paulbalandan approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think the proper fix for this would be to implement an always used method extension in phpstan-codeigniter. For now, I think this is good.

@paulbalandan paulbalandan merged commit 131c5eb into codeigniter4:develop Jan 10, 2025
39 checks passed
@neznaika0 neznaika0 deleted the refactor/phpstan-method-unused branch January 10, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@samsonasik samsonasik samsonasik approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neznaika0 @michalsn @samsonasik @paulbalandan