chore(deps-dev): update rector/rector requirement from 2.0.8 to 2.0.9 #9447
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version. - [Release notes](https://github.com/rectorphp/rector/releases) - [Commits](rectorphp/rector@2.0.8...2.0.9) --- updated-dependencies: - dependency-name: rector/rector dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
I've re-run rector to apply |
|
Ready to merge 👍 |
|
I have mixed feelings about this rule. Doesn't it work as a check on the We have a similar "problem" in Shield - https://github.com/codeigniter4/shield/actions/runs/13240274064/job/36953902890 and I was going to skip these rules. |
There was a problem hiding this comment.
I've checked the code of assertEmpty and it seems that for countables, like arrays, the comparison is the count compared against zero. The other case is the call to empty.
In my opinion, the test code did not change as it is still using the count assertion under the hood. However, we want things to be explicit just like how rector is doing things, but this change is I believe going backwards against rector's principles. It's no longer explicit to what you are asserting. I'm not even sure why it's under code quality. No offense meant.
This reverts commit 65b71e9. fix: skip rector.php
|
@michalsn @paulbalandan thank you for the reivew, I reverted the change and skip the |
|
Ready to merge 👍 |
|
Let's merge 👍 |
Updates the requirements on rector/rector to permit the latest version.
Release notes
Sourced from rector/rector's releases.
Commits
4393230Rector 2.0.9a291726Updated Rector to commit 3b14af26db9eef322f21a9c783e6f9109e087c67d79d968Updated Rector to commit 3569d162bf6cb3730c091db0898798e59c93b4f4767bb46Updated Rector to commit 70920b211391beb82fd05c269e6689e50b43098820f374aUpdated Rector to commit 59d4bca60c0cc1efb8061524e0425454cb432bc8ead5e52Updated Rector to commit ecd8b37aa8ad07d8618606124699175572de63f4Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)