Update visual sample dependencies #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The samples us some third-party libraries which have moved on since these were ported to Magnum. Especially compatibility with CMake 4 and newer; in addition some warnings have been fixed in third-party headers. On the other hand the APIs have had some updates, so the code has been updated to dodge some new deprecations.
Collaborator
|
Huh, apparently the CI is misconfigured to run on push to any branch (instead of just main) as well as on PRs. The The PR page displays results of both together, but the failed |
rafbiels
reviewed
Jun 26, 2025
they explain why we need the no-warn flag
rafbiels
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The samples us some third-party libraries which have moved on since these were ported to Magnum. Especially compatibility with CMake 4 and newer; in addition some warnings have been fixed in third-party headers.
On the other hand the APIs have had some updates, so the code has been updated to dodge some new deprecations.