fix: ssh connection to a workspace is established only once #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- right now ssh automatically connects to the workspace when a user selects it from the main env. page. However, if the user manually disconnects from the hamburger menu, the SSH is no longer automatically established afterward. - the reason for this behavior was that the connection request flag that triggered the ssh connection behind the scenes was never reset. In order to reset we have to know when a user hits the disconnect button. - fortunately Toolbox provides two callbacks, one before establishing the ssh connection and another one right after disconnect. Even though we don't know the reason for disconnect it's still a good opportunity to reset the request flag. - resolves #38
matifali
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now ssh automatically connects to the workspace when a user selects it from the main env. page. However, if the user manually disconnects from the hamburger menu, the SSH is no longer automatically established afterward.
the reason for this behavior was that the connection request flag that triggered the ssh connection behind the scenes was never reset. In order to reset we have to know when a user hits the disconnect button.
fortunately Toolbox provides two callbacks, one before establishing the ssh connection and another one right after disconnect. Even though we don't know the reason for disconnect it's still a good opportunity to reset the request flag.
resolves SSH connection to a Workspace is established only once #38