fix: go to previous step when connection fails #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fioan89
commented
Apr 9, 2025
fioan89
commented
- happens when an error is encountered during connection (like exceptions caused by an expired token)
- right now the auth wizard stays on the last step.
- with this changeset the auth steps reset to the initial sign in for auto-connect, or it goes back one step back to the token input step for manual authentication
- happens when an error is encountered during connection (like exceptions caused by an expired token) - right now the auth wizard stays on the last step. - with this changeset the auth steps reset to the initial sign in for auto-connect, or it goes back one step back to the token input step for manual authentication
matifali
approved these changes
Apr 10, 2025
|
Does this mean we go back to the enter deployment URL screen without pressing the back button? |
In the case of "auto-login" yes, it jumps back to the initial deployment url and it also shows an error notification. For the manual login sequence, it goes back only one step - to the token page and similarly it shows a notification error. |
|
@fioan89, can you ask for reviews from @f0ssel instead of @bcpeinhardt going forward? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.