Skip to content

feat: support more cli options #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 16, 2025
Merged

feat: support more cli options #9

merged 10 commits into from
Apr 16, 2025

Conversation

DanielleMaywood
Copy link
Collaborator

@DanielleMaywood DanielleMaywood commented Apr 16, 2025

Add support for:

  • --locale
  • --app-name
  • --welcome-text
  • --verbose
  • --trusted-origins
  • --enable-proposed-api
  • --proxy-domain

@DanielleMaywood DanielleMaywood self-assigned this Apr 16, 2025
@DanielleMaywood DanielleMaywood requested a review from Copilot April 16, 2025 14:01
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 12 changed files in this pull request and generated no comments.

Files not reviewed (11)
  • Makefile: Language not supported
  • src/code-server/devcontainer-feature.json: Language not supported
  • src/code-server/install.sh: Language not supported
  • test/code-server/code-server-app-name.sh: Language not supported
  • test/code-server/code-server-enable-proposed-api.sh: Language not supported
  • test/code-server/code-server-locale.sh: Language not supported
  • test/code-server/code-server-proxy-domain.sh: Language not supported
  • test/code-server/code-server-trusted-origins.sh: Language not supported
  • test/code-server/code-server-verbose.sh: Language not supported
  • test/code-server/code-server-welcome-text.sh: Language not supported
  • test/code-server/scenarios.json: Language not supported
Comments suppressed due to low confidence (1)

src/code-server/README.md:30

  • [nitpick] The description for 'enableProposedAPI' might be ambiguous since CLI flags are typically booleans; consider clarifying if this option should accept a list of extension IDs or act as a simple toggle flag.
| enableProposedAPI | Comma-separated list of VS Code extension IDs to enable proposed API features for. | string | - |

@DanielleMaywood DanielleMaywood marked this pull request as ready for review April 16, 2025 16:42
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍🏻

@DanielleMaywood DanielleMaywood merged commit f999968 into main Apr 16, 2025
8 checks passed
@DanielleMaywood DanielleMaywood deleted the dm-add-more-options branch April 16, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants