chore: update tests to remove extraneous provider blocks, go mod tidy #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
changed the title
mtojek
reviewed
May 23, 2024
Member
mtojek
left a comment
mtojek
left a comment
There was a problem hiding this comment.
note: terraform-plugin-sdk requires go 1.21 as of v2.33:
hashicorp/terraform-plugin-sdk@v2.32.0...v2.33.0
Considering the fact that we needed some time to update and tidy all kaniko's dependencies, my recommendation is to leave for the next week (between sprints).
Anyway, can we make smaller steps between versions first? This way we can identify the problematic commit/library.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#226 needs some help to get it over the finish line.
Removed provider blocks in tests as the plugin test framework appears to insert them automatically
note: terraform-plugin-sdk requires go 1.21 as of v2.33:
hashicorp/terraform-plugin-sdk@v2.32.0...v2.33.0