feat: add resources_monitoring field to agent

[defelmnq]

As required per this issue - we need to add a new field in terraform-provider-coder , more specifically in the agent.

[DanielleMaywood]

LGTM

[dannykopping]

Blocking this from accidental merge since we already have one approval, but some work is still required for validation.

[defelmnq]

@mtojek @dannykopping - I improved the validation and added test cases for all the main cases, should be way better now. ✅

[defelmnq]

I added some more cases to ensure we test all new fields and options.

Just a point remaining to discuss based on what we want to do around the duplicates validation. More details on this comment but globally I copy pasted metadata - still if there's any better place I am open to change it.

Otherwise I tested the tf-provider with coder/coder and it works exactly as we want - so I'm happy about the current behavior.

[matifali]

I have two suggestions.

1. Can we add an error that provider emits if someone tries to use resource_monitoring with Coder version 2.19 and below? The Error should tell the user what minimum Coder version the provider needs for this feature to work.
2. Tag the upcoming release as v2.2.0. We can also use v2.2.0-rc.0 until we release a compatible Coder release and then move to v2.2.0.

   One downside of an RC release is that if we fix anything else, we need to do a patch from main that will include this new feature. I also do not want us to release from branches.

WDYT @johnstcn as we recently spoke about versions for our provider?

[defelmnq]

I'll indeed defer answers to your questions to @johnstcn - not sure if this is doable and how , but happy to implement the check if we want to.

About the versioning, both are fine to me. I already tested it a lot with the Coder code we will deploy but a rc can be good too.

[dannykopping]

LGTM!

[mtojek]

Nice!

[johnstcn]

I have two suggestions.

1. Can we add an error that provider emits if someone tries to use resource_monitoring with Coder version 2.19 and below? The Error should tell the user what minimum Coder version the provider needs for this feature to work.

It should be possible to hit the /api/v2/buildinfo endpoint. We can't import codersdk here though so we'd need to do a little bit of copying. But it should definitely be possible! I think that's a good follow-up PR.

2. Tag the upcoming release as v2.2.0. We can also use v2.2.0-rc.0 until we release a compatible Coder release and then move to v2.2.0.

   One downside of an RC release is that if we fix anything else, we need to do a patch from main that will include this new feature. I also do not want us to release from branches.

WDYT @johnstcn as we recently spoke about versions for our provider?

I'm fine with RC releases. It's a little annoying to have to cherry-pick each time, but it's not the end of the world.