Create fifo as RUN_AS_USER, so watchdogs can use fifos #18
Conversation
breaks ppid, so watchdogs can't check if parent is dead. See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=604993;msg=17
| #include <grp.h> // for getgrnam() | ||
|
|
||
| /* Change this to the user under which to run */ | ||
| #define RUN_AS_USER "daemon" |
There was a problem hiding this comment.
Here we have RUN_AS_USER independently defined in two different files. This does not look good.
|
Hi Peter. Thanks for your pull request. Unfortunately it has some shortcomings which we would like you to address before we can accept it. Also, lately we had to "formalize" accepting contributions from 3rd parties. To this end I have pushed contributor agreement files to the repo. Please pull and read the CONTRIBUTOR_AGREEMENT.txt and if you agree to it, sign the CONTRIBUTORS.txt file by putting your name and github login in it. Finally it would be nice if you could rebase everything into a single commit. Thanks, |
|
Hi Alex, The bash stuff wasn't supposed to be committed, now I know why I should use branches :) I'll read the agreement and fix the stuff you mentioned. Peter |
We require watchdogs to change weight of the Galera servers, so they should have access to the fifo glbd creates.