Fix 4x speed at wendigo #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlward
commented
Nov 5, 2022
| @@ -2271,7 +2271,6 @@ def fullheal(target: int, direction: str): | |||
|
|
|||
|
|
|||
| # Process written by CrimsonInferno | |||
| @battle.utils.speedup_decorator | |||
There was a problem hiding this comment.
This fixes the wendigo fight, tested it on my machine.
jlward
commented
Nov 5, 2022
|
|
||
| def wrapper(*args, **kwargs): | ||
| if game_vars.get_battle_speedup(): | ||
| logger.debug(f"Speeding battle up: {func.__name__}") | ||
| monitor = threading.Thread(target=_monitor_battle) | ||
| monitor = threading.Thread(target=_monitor_battle, daemon=True) |
There was a problem hiding this comment.
This fixes the CTRL-C issue when you kill the TAS during combat when 4x speed is auto-enabled for combat. Also tested this locally.
jlward
commented
Nov 5, 2022
| @@ -490,23 +490,23 @@ def advanced_battle_logic(): | |||
| # Double Gemini, two different locations | |||
| if memory.main.get_use_items_slot(42) < 100: | |||
| battle.main.use_item( | |||
| memory.main.get_use_items_slot(42), rikku_flee=False | |||
| memory.main.get_use_items_slot(42), rikku_flee=True | |||
There was a problem hiding this comment.
According to @coderwilson these all needed to be toggled, I have not actually tested this yet, but plan to either tonight or tomorrow.
MrTyton
reviewed
Nov 5, 2022
MrTyton
approved these changes
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.