Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compatibility try #18

Closed

Conversation

Blind4Basics
Copy link
Contributor

@Blind4Basics Blind4Basics commented May 18, 2021

I got a different kind of error, locally, and could get the stdout properly with this.

new error is:

Traceback (most recent call last):
  File ".../GitHub/python-test-framework/tests/test_outputs.py", line 28,
in test
    self.assertRegex(result.stdout.decode("utf-8"), expected)
AssertionError: Regex didn't match: '\n<DESCRIBE::>group 1\n\n<PASSED::>Test Passed\n\n<PASSED::>Test Passed\n\n<COMPLETEDIN::>\\d+(?:\\.\\d+)?\n' not found in 'Fatal Python error: _Py_HashRandomization_Init: failed to get random numbers to initialize Python\nPython runtime state: preinitialized\n\n'

Wanting to see how this behaves here...

edit: "reason" for the stderr change: https://stackoverflow.com/questions/10406532/python-subprocess-output-on-windows

@Blind4Basics
Copy link
Contributor Author

Blind4Basics commented May 18, 2021

errrr....... I fear I did something wrong, there...
Did I push at the wrong place?

edit: ah, no, that's the write access apparently... But so, I cannot see if that works... ('should have use my fork, I guess...)

@kazk
Copy link
Member

kazk commented May 18, 2021

No, let me merge #17 first, and I'll rebase this so the test will run for Windows.

@kazk kazk force-pushed the window-compatibility-try branch from 0a6eb33 to 5f40bb7 Compare May 18, 2021 19:32
@Blind4Basics
Copy link
Contributor Author

Blind4Basics commented May 18, 2021

nice, now macos fails too... x/

That should be manageable, adding specific executions (sys stuff)


any idea about what's going on with this?

'Fatal Python error: _Py_HashRandomization_Init: failed to get random numbers to 
initialize Python\nPython runtime state: preinitialized\n\n

@kazk
Copy link
Member

kazk commented May 18, 2021

macOS is failing because it has exceptions prefix to error classes.

<type 'exceptions.ArithmeticError'> instead of the expected <type 'ArithmeticError'>.

@kazk
Copy link
Member

kazk commented May 18, 2021

Windows is failing because of the CRLF line ending (\r\n`).

Nevermind, it's 'Fatal Python error: failed to get random numbers to initialize Python\r\n\r\n'

@kazk
Copy link
Member

kazk commented May 18, 2021

I guess for Windows you need to pass SYSTEMROOT environment variable to the subprocess. appveyor/ci#1995 (comment)

@kazk
Copy link
Member

kazk commented May 18, 2021

OK, now it's failing because of the CRLF line ending (\r\n).

@kazk
Copy link
Member

kazk commented May 18, 2021

That shouldn't be necessary. Windows is failing because it includes a comma ZeroDivisionError('integer division or modulo by zero',) :(

@Blind4Basics
Copy link
Contributor Author

dunno... The more we dig, the craziest all of this seems... XD

Let's just drop windows support...

@kazk
Copy link
Member

kazk commented May 18, 2021

Let's just drop windows support...

We never supported it, so no problem.

@kazk kazk closed this May 18, 2021
@Blind4Basics Blind4Basics deleted the window-compatibility-try branch May 18, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants