-
Notifications
You must be signed in to change notification settings - Fork 0
Add patricia tree doc #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is an excellent job. Many thanks! |
This is a good idea, although we may want to mark it as work in progress. I think the best would be to say which modules have a stable interface and which do not, start making a large codex review where we would document (and also, question the design) of everything module per module. |
Indeed. Maybe reviewing the doc would be nice but we can do it when we review the code. |
Do you have an idea of other pages that would be missing a TOC? |
Is there a point in doing this? Commiting the JSON files seem to be sufficient. |
Maybe we can try to setup hackathon for these specific topics, and could group these TODOs as issues of the website. Other than that, I think the merge request is ready? |
Yes, I haven't added it yet because I wasn't sure how usable/commented codex interfaces are, or if they are commented, if they correctly use odoc syntax (
This is why we have a documentation version for the main branch, it is experimental and allows seeing how the documentation will look once we release. It isn't much of a problem if that version breaks, since the vX.Y.Z version would still be accesible (and the recommended way to browse the docs).
Not currently, the only other pages are nutshells which are rather short. However, if we want to add tutorials/explanation not generated by odoc, it might useful to have.
Yes it works fine. The rationale for this was that if we setup a CI auto-update, we might start polluting history with a lot of auto-generated commits, but I don't think it matters too much. For TODOs, I think the main one is adding the codex doc. Everything else is a "nice to have but entirely optional" feature. Also yes the PR is ready. I marked it as draft yesterday because I ran out of battery while creating it and wanted to make sure I hadn't forgotten anything. |
@mlemerre Once you merge this I can release version 0.10.0 |
Changes:
dune build @doc-json
and placed in_data/api/patricia-tree
.dune build @doc-json
, providedsherlodoc
is installed) have to be placed in/assets/js/sherlodoc-db
_includes/component/sidebar
to add a table of contents (only appears on odoc pages for now, it might be possible to extend it to also have a TOC on other pages of the website)._layout/vendor/compress.html
) to disable it on the odoc pages as it screws with rendering (see https://git.frama-c.com/pub/pub.frama-c.com/-/issues/26 for details)assets/js/zzzz-search-index.json
to include the odoc pages in the search. I've only added the latest version of the documentation to the search index. However, this still produces a lot of results (especially for functions/modules which appear multiple, e.g. BaseMap)Things I haven't done that we should consider: