Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pinning nim-eth dependency #77

Merged
merged 3 commits into from
Oct 22, 2024
Merged

fix: pinning nim-eth dependency #77

merged 3 commits into from
Oct 22, 2024

Conversation

AuHau
Copy link
Member

@AuHau AuHau commented Oct 16, 2024

Pins nim-eth to a working version.

Fixes compilation errors with nim v2.2.0.

First compilation error was a symbol clash for fromJson:

/home/runner/.nimble/pkgs2/serde-1.2.1-3596e180893eb8035d42cd1d778d2eff8f8fca25/serde/json/deserializer.nim(163, 19) Error: ambiguous call; both deserializer.fromJson(T: typedesc[enum], json: JsonNode) [proc declared in /home/runner/.nimble/pkgs2/serde-1.2.1-3596e180893eb8035d42cd1d778d2eff8f8fca25/serde/json/deserializer.nim(54, 6)] and conversions.fromJson(T: typedesc[E: TransactionStatus or TransactionType], json: JsonNode) [proc declared in /home/runner/work/nim-ethers/nim-ethers/ethers/providers/jsonrpc/conversions.nim(97, 6)] match for: (typedesc[TransactionType], JsonNode)

Second error was another ambiguous symbol for fail inside the tests.

@AuHau AuHau merged commit 53e596e into main Oct 22, 2024
4 checks passed
@AuHau AuHau deleted the fix/nim-eth-pin branch October 22, 2024 08:39
@emizzle
Copy link
Contributor

emizzle commented Oct 22, 2024

Pinning nim-eth is a temporary fix until proper versioning is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants