fix: block filters can be also recreated #88
Conversation
| if event =? E.decode(log.data, log.topics): | ||
| handler(event) | ||
| handler(success(event)) |
There was a problem hiding this comment.
Wouldn't you just want to pass in the result of E.decode? It returns ?!E already, and that way decoding errors won't get swallowed.
| if blckResult.isErr: | ||
| blockSubscriptionError = blckResult.error() | ||
| blockEvent.fire() | ||
|
|
||
| let blck = blckResult.value |
There was a problem hiding this comment.
Needs a return in the if block. Also, blockSubscriptionError = nil should be set somewhere to "reset" the error?
Can also do:
blockSubscriptionError = nil
without blck =? blckResult, error:
blockSubscriptionError = error
blockEvent.fire()
| ContractError* = object of EthersError | ||
| SignerError* = object of EthersError | ||
| SubscriptionError* = object of EthersError | ||
| SubscriptionResult*[E] = Result[E, ref SubscriptionError] |
There was a problem hiding this comment.
SubscriptionResult definitely works... but sometimes it can be a more of a pain than it's worth, mostly when needing to convert between different Result types when only the error type is different (eg using some flavour of mapErr). You can still return specific error types when it needs inspection at the callsite (since they inherit from CatchableError). See the reservations module for examples on how to do this, eg https://github.com/codex-storage/nim-codex/blob/ebee85b1aae05e50839a8f7e911ea888cff209bc/codex/sales/reservations.nim#L273 -- notice the return type of updateAvailability is ?!void, but here we're returning a specific error type). This is the pattern I'd suggest: return/parameter types should ?!T, then return specific error types where needed.
Adds Result to the Subscription's handlers that will return errors when any error in the underlaying subscription mechanism (for example HTTP polling) surface.