-
-
Notifications
You must be signed in to change notification settings - Fork 63
Laravel 12.x Compatibility #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch. To do so, temporarily add Shift's fork to the {
"repositories": [
{
"type": "vcs",
"url": "https://github.com/laravel-shift/laravel-localized-routes.git"
}
]
} Then update your dependency constraint to reference this branch: {
"require": {
"codezero/laravel-localized-routes": "dev-l12-compatibility",
}
} Finally, run: |
@ivanvermeyen can you check and merge this please? |
Just curious, but has this been abandoned? Update: I just forked the repo to update it myself. I don't know you at all, Ivan, but thank you for what you've done here. Rest in peace... |
Hello, Greetings |
@glennvermeyen I'm not sure how to go about this, but I have forked both this package, as well as the other required codezero-be-packages for it. I found that 'codezero/laravel-uri-translator' needed to be updated with support for Laravel v.12 too. And then, because of Laravel 12 (it seems), some tests for 'laravel-localized-routes' did not pass - those errors I fixed in my own forked version. Do you know if: A: Is it possible at all to get the changes merged into the org. packages? Thanks for whatever you can answer :) |
Did not expect this while looking for a PR. Thoughts to everyone who knew him and thanks for everything Ivan. ❤️ |
We're deeply saddened to hear about Ivan Vermeyen's passing. To continue support for this valuable package, OP.GG has created a fork with Laravel 12 compatibility: https://github.com/opgginc/codezero-laravel-localized-routes We'll maintain the package's integrity while ensuring compatibility with the latest Laravel versions. |
Nice @kargnas ! I can see that my changes are added to the new release version, specifically the tests that failed with Laravel 12. Thanks for notifying |
Just a heads up, as I can see you've forked my forked version of this repo. Additionally, I have switched to use their repo myself. It shouldn't have any impact for you. But I just wanted to let you know anyway :) |
@MartinLindalHansen Thanks for the headsup! I will switch as well 🙏 |
This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 12.x.
Before merging, you need to:
l12-compatibility
branchIf you do find an issue, please report it by commenting on this PR to help improve future automation.