Skip to content

Laravel 12.x Compatibility #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 12.x.

Before merging, you need to:

  • Checkout the l12-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 12. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-localized-routes.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "codezero/laravel-localized-routes": "dev-l12-compatibility",
    }
}

Finally, run: composer update

@jarivanb
Copy link

jarivanb commented Feb 26, 2025

@ivanvermeyen can you check and merge this please?

@MartinLindalHansen
Copy link

MartinLindalHansen commented Apr 2, 2025

Just curious, but has this been abandoned?
I see the tests have failed, but it seems more related to the Github action versioning in use.

Update:

I just forked the repo to update it myself.
Then I learned that the required package 'codezero/laravel-uri-translator' also needs to support Laravel v.12, which one guy have made ready, but it is also not merged.
Reading through the thread of that package update, I learned that @ivanvermeyen has sadly passed away.

I don't know you at all, Ivan, but thank you for what you've done here. Rest in peace...

@glennvermeyen
Copy link

Hello,
I have to inform you that this package will not be maintained in the future. Sadly Ivan has passed away last year. Feel free to make a fork.

Greetings

@MartinLindalHansen
Copy link

MartinLindalHansen commented Apr 2, 2025

Hello, I have to inform you that this package will not be maintained in the future. Sadly Ivan has passed away last year. Feel free to make a fork.

Greetings

@glennvermeyen I'm not sure how to go about this, but I have forked both this package, as well as the other required codezero-be-packages for it.

I found that 'codezero/laravel-uri-translator' needed to be updated with support for Laravel v.12 too.

And then, because of Laravel 12 (it seems), some tests for 'laravel-localized-routes' did not pass - those errors I fixed in my own forked version.

Do you know if:

A: Is it possible at all to get the changes merged into the org. packages?
or
B: Is it allowed to make a 'stable' release of own forked versions, as my project requires "stable" as minimum-stability in composer.json ?

Thanks for whatever you can answer :)

@phadaphunk
Copy link

phadaphunk commented Apr 3, 2025

Did not expect this while looking for a PR. Thoughts to everyone who knew him and thanks for everything Ivan. ❤️

@kargnas
Copy link

kargnas commented Apr 6, 2025

We're deeply saddened to hear about Ivan Vermeyen's passing. To continue support for this valuable package, OP.GG has created a fork with Laravel 12 compatibility:

https://github.com/opgginc/codezero-laravel-localized-routes

We'll maintain the package's integrity while ensuring compatibility with the latest Laravel versions.

@MartinLindalHansen
Copy link

Nice @kargnas !

I can see that my changes are added to the new release version, specifically the tests that failed with Laravel 12.
I'll remove my own forked version, and make use of the new release. Perhaps contributing even further at some point.

Thanks for notifying

@MartinLindalHansen
Copy link

@phadaphunk

Just a heads up, as I can see you've forked my forked version of this repo.
I'm about to remove my forked version, from my own repo, as OP.GG has chosen to maintain their forked repo in the future (that's a lot of forks)

Additionally, I have switched to use their repo myself.

It shouldn't have any impact for you. But I just wanted to let you know anyway :)

@phadaphunk
Copy link

@MartinLindalHansen Thanks for the headsup! I will switch as well 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants