Add Laravel 12 support #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin van Baalen <[email protected]>
Signed-off-by: Robin van Baalen <[email protected]>
Signed-off-by: Robin van Baalen <[email protected]>
Signed-off-by: Robin van Baalen <[email protected]>
Signed-off-by: Robin van Baalen <[email protected]>
Signed-off-by: Robin van Baalen <[email protected]>
Signed-off-by: Robin van Baalen <[email protected]>
Signed-off-by: Robin van Baalen <[email protected]>
|
Hey, any updates on this? |
|
@ivanvermeyen would you mind looking at this PR to support Laravel 12? 😄 |
|
Hello, Greetings |
|
@glennvermeyen I'm so sorry to hear that; my condolences. |
|
Oh my god that's horrible news. My condolences. |
|
I am really sorry. Please accept my condolences |
|
Very sorry to hear that. My condolences, and thank you for letting us know. Ivan’s work is appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated most of the files but you might want to look into the automated testing process and which versions of PHP you want to keep supporting.
Laravel 12 supports
>8.2, you're currently at 8.1.Once this package supports Laravel 12, the "main" package,
codezero/laravel-localized-routescan also be updated.You might want to squash these commits, by the way 😉