Solved issue #475 Added fibonacci.py and test_fibonacci.py #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Please review this PR |
|
@czgdp1807 Please review this PR. If there are some changes required then tell me I will do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of what is fixed or changed
Please refer the above content. I have created fibonacci.py file which includes the code for multi-threaded fibonacci series and I have verified it and checked it twice before submitting. I have also created test for that as per the problem given. Please see that and tell me if anything to change or edit, I will do that. I really liked this project. I want to work in this project in GSOC 2025.
One thing also according to your example if we assume fib_multi(1) = fib_multi(2) = 1 then your examples are working but in the code I have assumed fib_multi(0)=fib_multi(1) = 1 and then the series follows.
Well, I think it is better to use threading here for faster and efficient calculation and threading will also take less space as compared to recursion approach.
Hello, I am Kushagra Prajapat, want to work on this project in GSOC 2025. It seems your project is interesting as it is more logically. Hence, I would like to work on this project.
Please allow me to contribute on this project.
Thank You