Skip to content

added c++ backend for cocktail sort #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
#include "misc_algorithms.hpp"

static PyMethodDef algorithms_PyMethodDef[] = {
{"cocktail_shaker_sort", (PyCFunction) cocktail_shaker_sort,
METH_VARARGS | METH_KEYWORDS, ""},
{"quick_sort", (PyCFunction) quick_sort,
METH_VARARGS | METH_KEYWORDS, ""},
{"bubble_sort", (PyCFunction) bubble_sort,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,4 +185,78 @@ static PyObject* insertion_sort(PyObject* self, PyObject* args, PyObject* kwds)
}


static PyObject* cocktail_shaker_sort_impl(PyObject* array, size_t lower, size_t upper, PyObject* comp) {
bool is_sorted = false;

while(!is_sorted){
is_sorted = true;

for(size_t i = lower; i < upper; i++){
PyObject* i_PyObject = PyLong_FromSize_t(i);
PyObject* i1_PyObject = PyLong_FromSize_t(i+1);
if(_comp(PyObject_GetItem(array, i_PyObject), PyObject_GetItem(array, i1_PyObject), comp) != 1){
PyObject* tmp = PyObject_GetItem(array, i1_PyObject);
PyObject_SetItem(array, i1_PyObject, PyObject_GetItem(array, i_PyObject));
PyObject_SetItem(array, i_PyObject, tmp);
is_sorted = false;
}
}

for (size_t i = upper - 1; i > lower; i--) {
PyObject* i_PyObject = PyLong_FromSize_t(i);
PyObject* i1_PyObject = PyLong_FromSize_t(i - 1);
if (_comp(PyObject_GetItem(array, i1_PyObject), PyObject_GetItem(array, i_PyObject), comp) != 1) {
PyObject* tmp = PyObject_GetItem(array, i1_PyObject);
PyObject_SetItem(array, i1_PyObject, PyObject_GetItem(array, i_PyObject));
PyObject_SetItem(array, i_PyObject, tmp);
is_sorted = false;
}
}
}
return array;
}

static PyObject* cocktail_shaker_sort(PyObject* self, PyObject* args, PyObject* kwds) {
PyObject *args0 = NULL, *start = NULL, *end = NULL;
PyObject *comp = NULL;
size_t lower, upper;

args0 = PyObject_GetItem(args, PyZero);
int is_DynamicOneDimensionalArray = _check_type(args0, &DynamicOneDimensionalArrayType);
int is_OneDimensionalArray = _check_type(args0, &OneDimensionalArrayType);
if (!is_DynamicOneDimensionalArray && !is_OneDimensionalArray) {
raise_exception_if_not_array(args0);
return NULL;
}

comp = PyObject_GetItem(kwds, PyUnicode_FromString("comp"));
if (comp == NULL) {
PyErr_Clear();
}

start = PyObject_GetItem(kwds, PyUnicode_FromString("start"));
if (start == NULL) {
PyErr_Clear();
lower = 0;
} else {
lower = PyLong_AsSize_t(start);
}

end = PyObject_GetItem(kwds, PyUnicode_FromString("end"));
if (end == NULL) {
PyErr_Clear();
upper = PyObject_Length(args0) - 1;
} else {
upper = PyLong_AsSize_t(end);
}

args0 = cocktail_shaker_sort_impl(args0, lower, upper, comp);
if (is_DynamicOneDimensionalArray) {
PyObject_CallMethod(args0, "_modify", "O", Py_True);
}

Py_INCREF(args0);
return args0;
}

#endif
4 changes: 4 additions & 0 deletions pydatastructs/linear_data_structures/algorithms.py
Original file line number Diff line number Diff line change
Expand Up @@ -658,6 +658,10 @@ def cocktail_shaker_sort(array: Array, **kwargs) -> Array:

.. [1] https://en.wikipedia.org/wiki/Cocktail_shaker_sort
"""
backend = kwargs.pop("backend", Backend.PYTHON)
if backend == Backend.CPP:
return _algorithms.cocktail_shaker_sort(array, **kwargs)

raise_if_backend_is_not_python(
cocktail_shaker_sort, kwargs.get('backend', Backend.PYTHON))
def swap(i, j):
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import random, timeit, functools, os, pytest
from pydatastructs import (OneDimensionalArray, Backend,
DynamicOneDimensionalArray, quick_sort, bubble_sort, selection_sort,
insertion_sort, is_ordered, linear_search, binary_search, jump_search)
insertion_sort, is_ordered, linear_search, binary_search, jump_search, cocktail_shaker_sort)

def _test_common_sort(sort, **kwargs):
cpp = Backend.CPP
Expand Down Expand Up @@ -52,6 +52,10 @@ def test_insertion_sort():
_test_common_sort(insertion_sort, size=2000)


@pytest.mark.xfail
def test_cocktail_shaker_sort():
_test_common_sort(cocktail_shaker_sort, size=2000)

@pytest.mark.xfail
def test_is_ordered():
cpp = Backend.CPP
Expand Down
20 changes: 19 additions & 1 deletion pydatastructs/linear_data_structures/tests/test_algorithms.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,25 @@ def test_counting_sort():
assert counting_sort(arr)._data == expected_arr

def test_cocktail_shaker_sort():
_test_common_sort(cocktail_shaker_sort)
array = OneDimensionalArray(int, [5, 3, 8, 6, 2])
cocktail_shaker_sort(array, backend=Backend.PYTHON)

assert array._data[:5] == [2, 3, 5, 6, 8]
array = OneDimensionalArray(int, [10, 1, 7, 4, 3])
cocktail_shaker_sort(array, backend=Backend.CPP)
assert array._data[:5] == [1, 3, 4, 7, 10]

array = OneDimensionalArray(int, [20, 15, 10, 5, 0])
cocktail_shaker_sort(array, backend=Backend.CPP)
assert array._data[:5] == [0, 5, 10, 15, 20]

array = OneDimensionalArray(int, [1, 2, 3, 4, 5])
cocktail_shaker_sort(array, backend=Backend.CPP)
assert array._data[:5] == [1, 2, 3, 4, 5]

array = OneDimensionalArray(int, [5, 4, 3, 2, 1])
cocktail_shaker_sort(array, backend=Backend.CPP)
assert array._data[:5] == [1, 2, 3, 4, 5]

def test_quick_sort():
_test_common_sort(quick_sort)
Expand Down
Loading