-
Notifications
You must be signed in to change notification settings - Fork 1.3k
javscript should target node.js #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just because it's fun.
Rust port of 94_War
Add tictactoe2 in C#
Sudoku in pascal
Rust 74 rock paper scissors
ruby version of 92_Trap
Apply black to the 00_Utilities/markdown_todo.py
Remove byte-order-marker pre-commit check as there would be many adjustments necessary
The break statement would prevent infinite loop when player choose 'o' or 'O'
Python: Add tests for bounce and bowling
- Rename files to follow PEP8 convention / make them testable - Add type annotations - Fix Flake8 issues - Variable naming - Add unit test
Introduces a new error message: ({start_x}, {start_y}) has no legal moves. Choose again. Closes #677 Additionally, add type annotations
Checkers (Python): Check if field has valid moves
Bug (Python): Refactoring
updated implementation with proper OO design, provided link to video
Boxing (Python): Split configuration from logic
* Add Unit Test * Add Type Annotations * Use variable/function names
Bullfight (Python): Refactoring
CI: Prevent large files from being added
* Use functions to structure code * Remove 1-line function * Use dataclass * Replace dictionaries by a list
Bullseye (Python): Refactoring
10aaf69
to
13483fb
Compare
implemented minimal html terminal emulator
13483fb
to
99ae40f
Compare
This is all fine, but we definitely want to be able to run the games in the browser as the end state for JS, somehow.. as long as that is retained it is all good! |
Hi @mojoaxel , I didn't close this on purpose. This was done automatically when the history was re-written for #681 I didn't see this PR 🙈 As there were super many changes, I hope those were done automatically 🤞 If not and if this was a bigger amount of work, we could temporarily restore the old state. Otherwise, I suggest you to do the following:
Sorry for the inconvenience. |
No problem! I'll rebase my branch. |
These games are meant as simple CLI scripts (see #117 (comment)).
I therefor think javascript should target mainly node.js instead of the browser (in opposite of whats currents implemented).
print
,input
andtab
. (see Intellij complains about dependencies in ConsoleTest.kt. #548 (comment)).*.mjs
extension.Here is an example of the emulator in action: https://mojoaxel.github.io/basic-computer-games/00_Common/javascript/WebTerminal/terminal.html#74_Rock_Scissors_Paper/javascript/rockscissors.mjs
This way we have the best of both worlds:
This is only a DRAFT for now and I need to clean it up a little more over the next days.
Please let me know what you think!!