Skip to content

Remove tests and alternative Python implementations #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

MartinThoma
Copy link
Collaborator

Ad discussed here:
#548 (comment)

@MartinThoma
Copy link
Collaborator Author

MartinThoma commented Mar 29, 2022

Now Python shines xD

$ cloc . --exclude-dir 00_Utilities 
    2757 text files.
    1634 unique files.                                          
    1401 files ignored.

github.com/AlDanial/cloc v 1.82  T=0.91 s (1495.7 files/s, 155768.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                     101           1950           1186          23622
C#                             302           3534           4035          18853
Java                           150           3820           3483          16582
Visual Basic                   125            355            309          13323
Python                          94           3230           2525          12902
Perl                            62           1547           1424           5300
Ruby                            43            980            689           4144
Markdown                       169           1371              0           2922
Rust                            16            319            599           2356
JSON                             9              0              0           1909
HTML                           104             30              1           1257
Pascal                          12            147             33           1251
MSBuild script                 133            105              0           1156
Kotlin                          11            172            216           1067
D                                7             62             48            613
Elm                              2            223             14            495
C                                1             71             54            349
Jupyter Notebook                 1              0            238             90
YAML                             3              8              2             86
Go                               1              5              6             76
Lua                              1             25              0             75
TOML                            10             14              6             61
Bourne Shell                     1             12             33             55
-------------------------------------------------------------------------------
SUM:                          1358          17980          14901         108544
-------------------------------------------------------------------------------

I wish there was a tool like cloc that could check the complexity of the implementation (e.g. like radon, but for multiple languages)

Copy link
Collaborator

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the alternative implementation 01_Acey_Ducey/python/acey_ducey_oo.py ? I see no reason why we should not have those? I think it is a good idea to have multiple different implementations!

@coding-horror coding-horror merged commit 08ddffe into main Mar 29, 2022
@coding-horror coding-horror deleted the one-file-rule branch March 29, 2022 20:10
@coding-horror
Copy link
Owner

coding-horror commented Mar 29, 2022

oh my bad -- let's put the alternate back in if we can? I also think it's OK to have a few different implementations, but only if people feel that there's a good rationale for the different implementation, other than "mine is different"? There definitely should be comments in the alternate implementation explaining why it exists.

MartinThoma added a commit that referenced this pull request Mar 30, 2022
MartinThoma added a commit that referenced this pull request Mar 30, 2022
rjrw pushed a commit to rjrw/basic-computer-games that referenced this pull request Dec 19, 2022
Remove tests and alternative Python implementations
rjrw pushed a commit to rjrw/basic-computer-games that referenced this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants