Skip to content

Replace call to self._clean_name with clean_name #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Replace call to self._clean_name with clean_name #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19000ad
Replace call to self._clean_name with clean_name
agsimmons Mar 27, 2023
c2036fe
Require django-storages>=1.6
agsimmons Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ classifiers = [
requires-python = ">=3.9"
dependencies = [
"django>=2.0",
"django-storages",
"django-storages>=1.6",
"boto3",
]

Expand Down
3 changes: 2 additions & 1 deletion s3file/storages_optimized.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from storages.backends.s3boto3 import S3Boto3Storage
from storages.utils import clean_name


class S3OptimizedUploadStorage(S3Boto3Storage):
Expand All @@ -16,7 +17,7 @@ class S3OptimizedUploadStorage(S3Boto3Storage):
def _save(self, name, content):
# Basically copy the implementation of _save of S3Boto3Storage
# and replace the obj.upload_fileobj with a copy function
cleaned_name = self._clean_name(name)
cleaned_name = clean_name(name)
name = self._normalize_name(cleaned_name)
params = self._get_write_parameters(name, content)

Expand Down