Fix corrupted Vec creation in util::read_spir_v_file
#21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was debugging some strange memory problems and noticed that jemalloc would regularly freak out when Rust drops the buffer containing my shader bytecode. I traced it to this method.
Using
Vec::from_raw_parts
unfortunately can corrupt the data on the heap unless the new and old types share the same size and alignment.https://doc.rust-lang.org/std/vec/struct.Vec.html#method.from_raw_parts
Instead, I used
slice::from_raw_parts
andto_vec()
which is an in-place call (no copies) and should not incur an additional performance hit. The buffers are now dropped safely on my end.Possibly related to #20--my issue has disappeared since this fix.